fix: ensure Discord channels are created for all new bookmark lists #3

Merged
huantrinh1802 merged 1 commit from fix/discord-new-group-channel into main 2026-05-29 13:17:34 +10:00

Why:

  • When a bookmark belonged to multiple lists, the code broke at the first
    list that already had a Discord channel. Any new lists in the bookmark
    were skipped, so their forum channels were never created.

What:

  • Changed _sync_missed_bookmarks and _handle_crawled to use a two-pass
    approach:
    1. First pass: iterate all bookmark lists and create missing Discord
      channels for each one.
    2. Second pass: pick the first available channel to post the bookmark.
  • Added fallback to use bookmark list data directly when list info is not
    found in the pre-fetched list_map.

Impact:

  • New Karakeep groups/lists now correctly get their Discord forum
    channel created when a bookmark is saved to them.
Why: - When a bookmark belonged to multiple lists, the code broke at the first list that already had a Discord channel. Any new lists in the bookmark were skipped, so their forum channels were never created. What: - Changed _sync_missed_bookmarks and _handle_crawled to use a two-pass approach: 1. First pass: iterate all bookmark lists and create missing Discord channels for each one. 2. Second pass: pick the first available channel to post the bookmark. - Added fallback to use bookmark list data directly when list info is not found in the pre-fetched list_map. Impact: - New Karakeep groups/lists now correctly get their Discord forum channel created when a bookmark is saved to them.
Why:
- When a bookmark belonged to multiple lists, the code broke at the first
  list that already had a Discord channel. Any new lists in the bookmark
  were skipped, so their forum channels were never created.

What:
- Changed _sync_missed_bookmarks and _handle_crawled to use a two-pass
  approach:
  1. First pass: iterate all bookmark lists and create missing Discord
     channels for each one.
  2. Second pass: pick the first available channel to post the bookmark.
- Added fallback to use bookmark list data directly when list info is not
  found in the pre-fetched list_map.

Impact:
- New Karakeep groups/lists now correctly get their Discord forum
  channel created when a bookmark is saved to them.
huantrinh1802 deleted branch fix/discord-new-group-channel 2026-05-29 13:17:34 +10:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
huantrinh1802/karakeep_discord!3
No description provided.